On Wed, 27 Apr 2011 09:54:34 +0800
Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote:
> On 04/26/2011 09:29 PM, Anthony Liguori wrote:
> > On 04/26/2011 08:26 AM, Luiz Capitulino wrote:
> >> On Thu, 21 Apr 2011 11:23:54 +0800
> >> Lai Jiangshan<laijs@xxxxxxxxxxxxxx> wrote:
> >>
> >>>
> >>> Hi, Anthony Liguori
> >>>
> >>> Any suggestion?
> >>>
> >>> Although all command line interfaces will be converted to to use QMP interfaces in 0.16,
> >>> I hope inject-nmi come into QAPI earlier, 0.15.
> >>
> >> I don't know what Anthony thinks about adding new commands like this one that
> >> early to the new QMP interface, but adding them to current QMP will certainly
> >> cause less code churn on your side. That's what I'd recommend for now.
> >
> > Yeah, sorry, this whole series has been confused in the QAPI discussion.
> >
> > I did not intend for QAPI to be disruptive to current development.
> >
> > As far as I can tell, the last series that was posted (before the QAPI post) still had checkpatch.pl issues (scripts/checkpatch.pl btw) and we had agreed that once that was resolved, it would come in through Luiz's tree.
> >
>
> Sorry, I didn't caught the meaning.
> Fix checkpatch.pl issues of V7 Patch, and sent it again?
Yes, my recommendation for your series is:
1. Address checkpatch.pl errors
2. Change the HMP to use your implementation, which send the NMI
to all CPUs
3. Any other _code_ review comments I might be missing
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
