On 2011-04-27 10:55, Avi Kivity wrote: > On 04/24/2011 03:24 PM, Jan Kiszka wrote: >> > >> > This would cause IRQs to be delivered even if the PIT is masked, no? >> >> I checked the patch and our code again: NMI watchdog masking is managed >> via arch.vapics_in_nmi_mode and by re-checking the per-APIC mask >> situation in kvm_apic_local_deliver when delivering the NMI. >> >> So the patch looks correct - NMIs aren't acked like timer IRQs, the >> current logic is definitely wrong. > > Can you elaborate? Why aren't NMIs acked (if delivered via the PIC)? > Is the PIC programmed into auto-EOI mode or something? At least there are no traces of 8259 interaction in the NMI handler of old kernels when configured to IOAPIC mode. This wouldn't work anyway as you can't synchronize with other PIC-accessing functions from the NMI handler. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
