On 04/21/2011 04:02 AM, Takuya Yoshikawa wrote:
On Wed, 20 Apr 2011 15:33:16 +0200 "Roedel, Joerg"<Joerg.Roedel@xxxxxxx> wrote: > @@ -245,13 +257,17 @@ walk: > goto error; > > if (write_fault&& !is_dirty_gpte(pte)) { > - bool ret; > + int ret; > > trace_kvm_mmu_set_dirty_bit(table_gfn, index, sizeof(pte)); > - ret = FNAME(cmpxchg_gpte)(vcpu->kvm, table_gfn, index, pte, > + ret = FNAME(cmpxchg_gpte)(vcpu, mmu, table_gfn, index, pte, > pte|PT_DIRTY_MASK); > - if (ret) > + if (ret< 0) { > + present = false; > + goto error; > + } if (ret) > goto walk; Preferably else if or another line ? :)
Yes, I added an 'else' and applied. Thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html