On Wed, 20 Apr 2011 15:33:16 +0200 "Roedel, Joerg" <Joerg.Roedel@xxxxxxx> wrote: > @@ -245,13 +257,17 @@ walk: > goto error; > > if (write_fault && !is_dirty_gpte(pte)) { > - bool ret; > + int ret; > > trace_kvm_mmu_set_dirty_bit(table_gfn, index, sizeof(pte)); > - ret = FNAME(cmpxchg_gpte)(vcpu->kvm, table_gfn, index, pte, > + ret = FNAME(cmpxchg_gpte)(vcpu, mmu, table_gfn, index, pte, > pte|PT_DIRTY_MASK); > - if (ret) > + if (ret < 0) { > + present = false; > + goto error; > + } if (ret) > goto walk; Preferably else if or another line ? :) Takuya > + > mark_page_dirty(vcpu->kvm, table_gfn); > pte |= PT_DIRTY_MASK; > walker->ptes[walker->level - 1] = pte; > -- > 1.7.1 > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html