On Fri, Apr 8, 2011 at 2:48 PM, Pekka Enberg <penberg@xxxxxxxxxx> wrote: > Hi Prasad, > > Please don't put 'kvm tool' inside the brackets in the subject line. All > that gets stripped away. The correct form is: > > [PATCH v2 4/4] kvm tools: Using the Gitish framework to run the VM oh okay! > > On Fri, 8 Apr 2011, Prasad Joshi wrote: >> >> - kvm-run.[ch] Adds a new kvm command called 'run'. The most of the code >> is >> copied from main.c. >> >> - main.c is modified to use the functionality provided by framework. >> The old code from main.c is moved to kvm-run.c. >> >> Signed-off-by: Prasad Joshi <prasadjoshi124@xxxxxxxxx> > > This needs bit more fine-tuning: > > - The '--mem' command must not be a mandatory option. Use the > current default instead. > > - This form must still work after the patch: > > ./kvm run /boot/vmlinuz-2.6.39-rc2+ > > [ Btw, please fix up 'make check' in this patch as well. ] I will make the changes and resend all of the patches. Thanks a lot for your review comments. Thanks and Regards, Prasad > > Pekka > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
