On Mon, 14 Mar 2011 17:11:40 +0200
Gleb Natapov <gleb@xxxxxxxxxx> wrote:
> > @@ -3212,11 +3235,13 @@ special_insn:
> > break;
> > case 0xa6 ... 0xa7: /* cmps */
> > c->dst.type = OP_NONE; /* Disable writeback. */
> > - goto cmp;
> > + emulate_2op_SrcV("cmp", c->src, c->dst, ctxt->eflags);
> Why not call em_cmp() here?
I thought that I needed to check of
c->dst.type = OP_NONE; /* Disable writeback. */
later.
So I just decided to treat CMPS and SCAS in another patch.
I mean I may introduce em_cmps or em_scas later if needed.
You prefer to treat these in this patch?
> > + break;
> > case 0xa8 ... 0xa9: /* test ax, imm */
> > goto test;
> > case 0xae ... 0xaf: /* scas */
> > - goto cmp;
> > + emulate_2op_SrcV("cmp", c->src, c->dst, ctxt->eflags);
> And here?
What is the difference of CMPS and SCAS?
>
> > + break;
> > case 0xc0 ... 0xc1:
> > emulate_grp2(ctxt);
> > break;
> > --
> > 1.7.1
>
> --
> Gleb.
--
Takuya Yoshikawa <takuya.yoshikawa@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
