On 2011-02-23 12:42, Michael Tokarev wrote: > 23.02.2011 14:31, Jan Kiszka wrote: >> On 2011-02-23 12:04, Michael Tokarev wrote: >>> What's the current status of files in kvm/ subdirectory >>> in the qemu-kvm distribution (0.14 or git) ? > [] >> I think there are a few bits still in use: >> >> - kvm/kvm_stat > > this is a tiny useful tool, yes, and we package > it. > >> - kvm/include (latest kernel headers) *) > > This directory is always used (in configure) > unless -kerneldir is specified - who uses that > nowadays? I dunno. It may not be relevant to distros, provided they manage to keep their /usr/include/linux stuff in sync with the kernel they ship. But if you build qemu-kvm for a kernel (or kvm-kmod) that is more recent than your user space headers, this matters. > >> Otherwise, removing this cruft would be good. >> >> Jan >> >> *) This should really be discussed upstream again: Carry private copy of >> kvm headers or rely on distro / kvm-kmod to provide required defines, >> types etc.? I'm more and more in favor of option 1. > > Yes indeed, having current defines of all the features > we actually support is a good idea. Would you like to propose this upstream in form of a patch series (that demonstrates its usefulness by dropping tones of #ifdefs)? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
