On 02/07/2011 09:08 AM, Avi Kivity wrote:
On 02/07/2011 05:01 PM, Jan Kiszka wrote:
>
> On the other hand, we need a way to inject lost ticks into a
> PeriodicTimer. If interrupt injection detects that an interrupt was
> coalesced, we want the timer to schedule a new tick for us.
Isn't absence of corresponding call to periodic_timer_ack() sufficient?
It probably is. However, that API is easy to misuse; if you forget to
call it, the timer goes crazy. The default behaviour should be to
assume an ack and the API should provide adjustments.
I disagree. You typically only call it in one place and as such, if you
forget to add that call, you'll find out pretty quickly that you did
something wrong.
OTOH, accounting missed ticks is easy to not do correctly and it's hard
to get feedback when that happens.
Also need to design the API carefully for changing frequency (Windows
is known to do that) and switching from periodic to single shot. For
the first case I guess we need to adjust the deferred ticks to the new
time base (so if the frequency doubles, the lost ticks up to that
point double as well). For the second case, I guess we just lose time.
Bus cycle based one shot timers probably need to be treated as a special
case of changing an interval followed by setting the interval to zero.
For non-bus cycle based timers, it probably doesn't matter and is easy
to just use a one shot timer (like QEMUTimer).
Regards,
Anthony Liguori
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
