Re: [Qemu-devel] Re: [RFC: 0/2] patch for QEMU HPET periodic timer emulation to alleviate time drift

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/07/2011 05:01 PM, Jan Kiszka wrote:
>
>  On the other hand, we need a way to inject lost ticks into a
>  PeriodicTimer.  If interrupt injection detects that an interrupt was
>  coalesced, we want the timer to schedule a new tick for us.

Isn't absence of corresponding call to periodic_timer_ack() sufficient?

It probably is. However, that API is easy to misuse; if you forget to call it, the timer goes crazy. The default behaviour should be to assume an ack and the API should provide adjustments.

Also need to design the API carefully for changing frequency (Windows is known to do that) and switching from periodic to single shot. For the first case I guess we need to adjust the deferred ticks to the new time base (so if the frequency doubles, the lost ticks up to that point double as well). For the second case, I guess we just lose time.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux