On 01/31/2011 10:57 AM, Nadav Har'El wrote:
On Sun, Jan 30, 2011, Avi Kivity wrote about "Re: [PATCH 05/29] nVMX: Implement reading and writing of VMX MSRs": > >+ case MSR_IA32_VMX_TRUE_PINBASED_CTLS: > >+ case MSR_IA32_VMX_PINBASED_CTLS: > >+ vmx_msr_low = CORE2_PINBASED_CTLS_MUST_BE_ONE; > >+ vmx_msr_high = CORE2_PINBASED_CTLS_MUST_BE_ONE | > >+ PIN_BASED_EXT_INTR_MASK | > >+ PIN_BASED_NMI_EXITING | > >+ PIN_BASED_VIRTUAL_NMIS; > > Can we actually support PIN_BASED_VIRTUAL_NMIs on hosts which don't > support them? > > Maybe better to drop for the initial version. Thanks, I'll look into this. You already found this problem in June, and it's already in my bugzilla. Just wanted to let you know that I'm taking all your previous comments seriously, and not forgetting any of them. Since you mention this one again, I'm increasing its priority, so I'll fix it before the next version of the patches.
Thanks. Since I see many other comments are still unaddressed, I'll stop reviewing until you let me know that you have a version that is ready for review.
-- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
