On Tue, 2010-12-28 at 17:43 +0200, Michael Goldish wrote: > This is a respin of Eduardo's patchset with small modifications. > > Differences from Eduardo's patches: > - These patches don't change the module structure of the KVM test (no kvm > package is created). We can still do that in the future if we choose to. > - The class is named Env instead of KvmEnv. > - It's defined in kvm_utils.py instead of a module of its own. > - No unittests for Env. I personally don't think they're necessary, nor do I > think anyone will bother to use them, but let me know if you disagree. > - The __init__() method takes care of the loading if a filename is provided. > - save() can do what _dump() did, so _dump() is unnecessary. > - The series is a lot shorter and will hopefully be easier to review. Hi Michael, thanks! The only thing I do not agree is with the unittest, it's useful, specially for me when I am applying and checking the patches, so I ask you to send the unittest Eduardo created on a future patch. Other than that, great work! > Michael Goldish (4): > KVM test: introduce the Env class > KVM test: use kvm_utils.Env wherever appropriate > KVM test: use the new Env methods instead of the old env_* functions > KVM test: get rid of the kvm_utils.env_* functions > > client/tests/kvm/kvm.py | 12 +- > client/tests/kvm/kvm_preprocessing.py | 12 +- > client/tests/kvm/kvm_scheduler.py | 4 +- > client/tests/kvm/kvm_test_utils.py | 4 +- > client/tests/kvm/kvm_utils.py | 165 +++++++++++++++-------------- > client/tests/kvm/tests/ksm_overcommit.py | 4 +- > client/tests/kvm/tests/qemu_img.py | 6 +- > client/tests/kvm/tests/stepmaker.py | 2 +- > client/tests/kvm/tests/steps.py | 2 +- > client/tests/kvm/tests/stress_boot.py | 2 +- > client/tests/kvm/tests/unittest.py | 2 +- > client/tests/kvm/tests/virtio_console.py | 2 +- > 12 files changed, 111 insertions(+), 106 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
