On 12/17/2010 11:25 PM, Avi Kivity wrote: > On 12/17/2010 01:22 PM, Luiz Capitulino wrote: >> > >> > I think Avi's suggest is better, and I will use >> > "inject-nmi" (without cpu-index argument) to send NMI to all cpus, >> > like physical GUI. If some one want to send NMI to a set of cpus, >> > he can use "inject-nmi" multiple times. >> >> His suggestion is to drop _all_ arguments, right Avi? > > Yes. > We don't need to drop the cpu-index argument, the upstream tools(libvirt etc.) can just issue "inject-nmi" command without any argument when need. Reasons to keep this argument 1) Useful for kernel developer or debuger sending NMI to a special CPU. 2) Share the code with nmi of hmp version. Share the way how to use these two commands.(hmp version and qmp version) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
