On 11/18/2010 05:32 PM, Marcelo Tosatti wrote:
> >> There is no need to flush on sync_page path since the guest is > >> responsible for it. > >> > > > > If we don't, the next rmap_write_protect() will incorrectly decide that > > there's no need to flush tlbs. > > > > Maybe it's not a problem if guest can flush all tlbs after overwrite it? > Marcelo, what's your comment about this? It can, but there is no guarantee. Your patch is correct.
We keep tripping on the same problem again and again. spte.w (and tlb.pte.w) is multiplexed between guest and host, hence we cannot trust the guest regarding its consistency.
I wish we had a systematic way of dealing with this. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
