On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > On 11/10/10 18:34, Michael S. Tsirkin wrote: > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > >> > >>Signed-off-by: Gleb Natapov<gleb@xxxxxxxxxx> > > > >Good stuff. We should also consider using this for > >CLI and monitor. Some comments below. > > Oh, we already have a table to map pci classes to descriptions for > 'info pci'. I'd strongly suggest to just add the fw names to that > table instead of creating a second one ... > Do you mean pci_class_descriptions? For some classes open firmware spec defines single name for all subclasses. For instance all 0Axx should be called "dock" no matter what xx is. This can't be encoded in a simple table. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html