Re: [patch 1/2] qemu-kvm: use usptream eventfd code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 On 09/07/2010 08:25 PM, Marcelo Tosatti wrote:
On Tue, Sep 07, 2010 at 11:21:32AM +0300, Avi Kivity wrote:
  On 09/06/2010 11:20 PM, Marcelo Tosatti wrote:
Upstream code is equivalent.

Signed-off-by: Marcelo Tosatti<mtosatti@xxxxxxxxxx>

Index: qemu-kvm/cpus.c
===================================================================
--- qemu-kvm.orig/cpus.c
+++ qemu-kvm/cpus.c
@@ -290,11 +290,6 @@ void qemu_notify_event(void)
  {
      CPUState *env = cpu_single_env;

-    if (kvm_enabled()) {
-        qemu_kvm_notify_work();
-        return;
-    }
-
      qemu_event_increment ();
      if (env) {
          cpu_exit(env);
qemu_event_increment() is indeed equivalent, but what about the
rest?  Are we guaranteed that cpu_single_env == NULL?
No, its not NULL. But env->current is, so its fine.

Ok, thanks.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux