On Tue, Sep 07, 2010 at 11:21:32AM +0300, Avi Kivity wrote: > On 09/06/2010 11:20 PM, Marcelo Tosatti wrote: > >Upstream code is equivalent. > > > >Signed-off-by: Marcelo Tosatti<mtosatti@xxxxxxxxxx> > > > >Index: qemu-kvm/cpus.c > >=================================================================== > >--- qemu-kvm.orig/cpus.c > >+++ qemu-kvm/cpus.c > >@@ -290,11 +290,6 @@ void qemu_notify_event(void) > > { > > CPUState *env = cpu_single_env; > > > >- if (kvm_enabled()) { > >- qemu_kvm_notify_work(); > >- return; > >- } > >- > > qemu_event_increment (); > > if (env) { > > cpu_exit(env); > > qemu_event_increment() is indeed equivalent, but what about the > rest? Are we guaranteed that cpu_single_env == NULL? No, its not NULL. But env->current is, so its fine. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html