Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 07, 2010 at 10:14:46AM -0400, Alexander Graf wrote:
> 
> On 07.09.2010, at 16:12, Roedel, Joerg wrote:
> 
> > On Tue, Sep 07, 2010 at 09:51:33AM -0400, Avi Kivity wrote:
> >>  On 09/07/2010 03:23 PM, Alexander Graf wrote:
> >>> 
> >>> I think we should get rid of kvm_nested and -enable-nesting. Instead, we should enable the SVM bit in the "host" and "qemu64" cpu types, but not in "kvm64". This way users are safe to not use nested svm, but can choose to do so if they like.
> >>> 
> >>> Also, it should be possible to do something like -cpu kvm64,flags=+svm. Without having to mess with -enable-nesting.
> >> 
> >> I agree, -enable-nesting is redundant with -cpu ,+svm.
> > 
> > This patchset makes -enable-nesting pratically a synonym for -cpu ,+svm.
> > So we can safely remove -enable-nesting in the future.
> 
> Why not just not introduce it? :) It's always hard to get rid of legacy.

Because its already there? The patches are against qemu-kvm.

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux