Am 24.08.2010 14:06, schrieb Alexander Graf: >>> #define VIRTIO_SUBCODE_64 0x0D00 >>> +#define VIRTIO_PARAM_MASK 0xff >>> +#define VIRTIO_PARAM_VRING_INTERRUPT 0x0 >>> +#define VIRTIO_PARAM_CONFIG_CHANGED 0x1 >>> >> >> Maybe this should be exported in a header, something like >> arch/s390/include/asm/kvm_virtio.h? In that case this file >> must be added to Kbuild for make headers_install. >> > > While that thought sounds good at first, it's really no use for anyone, > right? I mean - in qemu we need to define the defines manually anyways > because we need to potentially be able to build the s390x target on > non-s390x, possibly on non-Linux. I have no strong opinion on that, but I think its more a matter of where to put an interface description. A header file seems just the right place. I will let you (or Rusty) decide. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
