Christian Borntraeger wrote: > Am 23.08.2010 23:31, schrieb Alexander Graf: > >> Currenty the ext_param field only distinguishes between "config change" and >> "vring interrupt". We can do a lot more with it though, so let's enable a >> full byte of possible values and constants to #defines while at it. >> > > Makes a lot of sense. > [...] > > >> #define VIRTIO_SUBCODE_64 0x0D00 >> +#define VIRTIO_PARAM_MASK 0xff >> +#define VIRTIO_PARAM_VRING_INTERRUPT 0x0 >> +#define VIRTIO_PARAM_CONFIG_CHANGED 0x1 >> > > Maybe this should be exported in a header, something like > arch/s390/include/asm/kvm_virtio.h? In that case this file > must be added to Kbuild for make headers_install. > While that thought sounds good at first, it's really no use for anyone, right? I mean - in qemu we need to define the defines manually anyways because we need to potentially be able to build the s390x target on non-s390x, possibly on non-Linux. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
