On 3/18/25 15:36, Richard Henderson wrote:
On 3/18/25 15:25, Pierrick Bouvier wrote:
On 3/18/25 15:21, Richard Henderson wrote:
On 3/18/25 15:16, Pierrick Bouvier wrote:
This doesn't make any sense to me. CPU_INCLUDE is defined within the very file that
you're trying to include by avoiding "cpu.h".
Every target/X/cpu.h includes cpu-all.h, which includes "cpu.h" itself, relying on per
target include path set by build system.
So, another solution would be to fix the silly include loop?
If you're ok with it, I'm willing to remove cpu-all.h completely (moving tlb flags bits in
a new header), and fixing missing includes everywhere.
I just wanted to make sure it's an acceptable path before spending too much time on it.
I would very much like cpu-all.h to go away.
Deal, I will complete the work, while being based on your current series
(v2).
It looks like we have, on tcg-next:
(1) cpu_copy is linux-user only, and should go in linux-user/qemu.h.
(2) the TLB flags certainly deserve their own header.
(3) The QEMU_BUILD_BUG_ON assertions need not be done in a header,
so long as there is *some* file that won't build if the assertions fail.
Perhaps cpu-target.c is as good as any.
Yes, I noticed it, and chose #ifdef COMPILING_PER_TARGET workaround to
not make a choice of where to move it.
r~
