On 10/3/25 14:51, Cédric Le Goater wrote:
On 3/10/25 14:43, Philippe Mathieu-Daudé wrote:
On 10/3/25 08:37, Cédric Le Goater wrote:
On 3/9/25 00:09, Philippe Mathieu-Daudé wrote:
Convert the compile time check on the CONFIG_VFIO_IGD definition
by a runtime one by calling vfio_igd_builtin(), which check
whether VFIO_IGD is built in a qemu-system binary.
Add stubs to avoid when VFIO_IGD is not built in:
I thought we were trying to avoid stubs in QEMU build. Did that change ?
Hmm so you want remove the VFIO_IGD Kconfig symbol and have it always
builtin with VFIO. It might make sense for quirks, since vfio_realize()
already checks for the VFIO_FEATURE_ENABLE_IGD_OPREGION feature.
I have explored this option in the past and it's much more work.
Stubs are fine IMO, if we can have them, but I remember someone
telling me (you ?) that we were trying to remove them.
We shouldn't have target-specific stubs.
(currently CONFIG_DEVICES::VFIO_IGD is target specific).
I don't think we can avoid host-specific stubs.
In unified binary, CONFIG_DEVICES disappears, VFIO_IGD
will be handled like host configuration. Although if possible I'd
rather remove VFIO_IGD, unconditionally including all quirks.
