On 3/10/25 21:43, Philippe Mathieu-Daudé wrote: > On 10/3/25 08:37, Cédric Le Goater wrote: >> On 3/9/25 00:09, Philippe Mathieu-Daudé wrote: >>> Convert the compile time check on the CONFIG_VFIO_IGD definition >>> by a runtime one by calling vfio_igd_builtin(), which check >>> whether VFIO_IGD is built in a qemu-system binary. >>> >>> Add stubs to avoid when VFIO_IGD is not built in: >> >> I thought we were trying to avoid stubs in QEMU build. Did that change ? > > Hmm so you want remove the VFIO_IGD Kconfig symbol and have it always > builtin with VFIO. It might make sense for quirks, since vfio_realize() > already checks for the VFIO_FEATURE_ENABLE_IGD_OPREGION feature. > > I'll see if there aren't other implications I missed. > > Thanks, > > Phil. I personally suggest keeping the VFIO_IGD Kconfig symbol to prevent building IGD-specific code into non x86 target. The change Cedric mentioned in another reply [1] moves VFIO_FEATURE_ENABLE_IGD_OPREGION from vfio_realize() to igd.c. [1] https://lore.kernel.org/qemu-devel/20250306180131.32970-1-tomitamoeko@xxxxxxxxx/ Thanks, Moeko
