On Tue, Feb 04, 2025 at 07:57:08PM +0000, Colton Lewis wrote: > perf/arm_pmuv3.h includes asm/arm_pmuv3.h at the bottom of the > file. This counterintiutive decision was presumably made so > asm/arm_pmuv3.h would be included everywhere perf/arm_pmuv3.h was even > though the actual dependency relationship goes the other way because > asm/arm_pmuv3.h depends on the PMEVN_SWITCH macro that was presumably > put there to avoid duplicating it in the asm files for arm and arm64. > > Extract the relevant macro to its own file to avoid this unusual > structure so it may be included in the asm headers without worrying > about ordering issues. > > Signed-off-by: Colton Lewis <coltonlewis@xxxxxxxxxx> Is the intention of this change to allow asm/arm_pmuv3.h to be directly included? If yes, what's the issue with using perf/arm_pmuv3.h? We already use definitions from the non-arch header in KVM anyway... -- Thanks, Oliver
