On 2/4/25 11:04, Stefano Garzarella wrote: > On Tue, 4 Feb 2025 at 10:59, Stefano Garzarella <sgarzare@xxxxxxxxxx> wrote: >> On Tue, Feb 04, 2025 at 01:38:50AM +0100, Michal Luczaj wrote: >>> ... >>> I'm not sure this is the most elegant code (sock_orphan(sk) sets SOCK_DEAD >>> on a socket that is already SOCK_DEAD), but here it goes: >>> https://lore.kernel.org/netdev/20250204-vsock-linger-nullderef-v1-0-6eb1760fa93e@xxxxxxx/ >> >> What about the fix proposed here: >> https://lore.kernel.org/lkml/20250203124959.114591-1-aha310510@xxxxxxxxx/ > > mmm, nope, that one will completely bypass the lingering, right? Right. Besides that, it's a transport-specific approach, so all the other transports would need their .release() tweaked. >>> One more note: man socket(7) says lingering also happens on shutdown(). >>> Should vsock follow that? >> >> Good point, I think so. >> IMHO we should handle both of them in af_vsock.c if it's possible, but >> maybe we need a bit of refactoring. >> >> Anyway, net-next material, right? Yeah, I guess. Michal
