On 2/4/25 6:35 PM, Mina Almasry wrote: > On Tue, Feb 4, 2025 at 4:29 AM Paolo Abeni <pabeni@xxxxxxxxxx> wrote: >>> .../selftests/drivers/net/hw/ncdevmem.c | 300 +++++++++++++++++- >>> 1 file changed, 289 insertions(+), 11 deletions(-) >> >> Why devmem.py is not touched? AFAICS the test currently run ncdevmem >> only in server (rx) mode, so the tx path is not actually exercised ?!? >> > > Yeah, to be honest I have a collection of local bash scripts that > invoke ncdevmem in different ways for my testing, and I have docs on > top of ncdevmem.c of how to test; I don't use devmem.py. I was going > to look at adding test cases to devmem.py as a follow up, if it's OK > with you, and Stan offered as well on an earlier revision. If not no > problem, I can address in this series. The only issue is that I have > some legwork to enable devmem.py on my test setup/distro, but the meat > of the tests is already included and passing in this series (when > invoked manually). I think it would be better if you could include at least a very basic test-case for the TX path. More accurate coverage could be a follow-up. Thanks, Paolo
