On Tue, Feb 4, 2025 at 4:29 AM Paolo Abeni <pabeni@xxxxxxxxxx> wrote: > > On 2/3/25 11:39 PM, Mina Almasry wrote: > > Add support for devmem TX in ncdevmem. > > > > This is a combination of the ncdevmem from the devmem TCP series RFCv1 > > which included the TX path, and work by Stan to include the netlink API > > and refactored on top of his generic memory_provider support. > > > > Signed-off-by: Mina Almasry <almasrymina@xxxxxxxxxx> > > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx> > > Usually the self-tests are included towards the end of the series, to > help reviewers building-up on previous patches knowledge. > I noticed reviewers like to go over docs + selftests in my previous series so I thought I'd put them in the beginning. Looks like the gambit was not welcome. I'll move the selftests to the end. May also move the docs to the end as is customary as well. > > .../selftests/drivers/net/hw/ncdevmem.c | 300 +++++++++++++++++- > > 1 file changed, 289 insertions(+), 11 deletions(-) > > Why devmem.py is not touched? AFAICS the test currently run ncdevmem > only in server (rx) mode, so the tx path is not actually exercised ?!? > Yeah, to be honest I have a collection of local bash scripts that invoke ncdevmem in different ways for my testing, and I have docs on top of ncdevmem.c of how to test; I don't use devmem.py. I was going to look at adding test cases to devmem.py as a follow up, if it's OK with you, and Stan offered as well on an earlier revision. If not no problem, I can address in this series. The only issue is that I have some legwork to enable devmem.py on my test setup/distro, but the meat of the tests is already included and passing in this series (when invoked manually). -- Thanks, Mina
