On 03/02/2025 11:18, Suzuki K Poulose wrote: > On 30/01/2025 16:40, Steven Price wrote: >> On 29/01/2025 04:50, Gavin Shan wrote: [...] >>> One corner case seems missed in kvm_vcpu_init_check_features(). It's >>> allowed to >>> initialize a vCPU with REC feature even kvm_is_realm(kvm) is false. >>> Hopefully, >>> I didn't miss something. >> >> Ah, yes good point. I'll pass a kvm pointer to >> kvm_vcpu_init_check_features() and use kvm_is_realm() in there. > > nit: kvm is available from the VCPU via vcpu->kvm Absolutely correct, and what I wrote was nonsense ;) What I meant was to pass a kvm pointer *from* kvm_vcpu_init_check_features() *to* system_supported_vcpu_features() and use kvm_is_realm() in there! Thanks, Steve
