On 1/15/25 11:20 AM, Claudio Imbrenda wrote:
On Wed, 15 Jan 2025 09:56:11 +0100
Janosch Frank <frankja@xxxxxxxxxxxxx> wrote:
On 1/8/25 7:14 PM, Claudio Imbrenda wrote:
Move some gmap shadowing functions from mm/gmap.c to kvm/vsie.c and
kvm/kvm-s390.c .
Why though?
to start removing stuff from mm
Alright, let me be more specific below.
I don't really want to have gmap code in vsie.c
If you want to add a new mm/gmap-vsie.c then do so but I don't see a
will do
kvm-s390.c is quite long already and the fault code in vsie.c has been a
thorn in my side for a couple of years as well since I have to jump
between gmap.c and vsie.c and gaccess.c when reading.
I don't mind putting the gmap.c code in the kvm/ dir but I don't want it
spread out over all of the kvm/*.c files and especially not over the two
main files.
We have gaccess.c which is memory centric.
Add a new file or two (since gmap.c is quite long and shadow code can be
split out) to kvm/.
need to move gmap code from mm to kvm and you give no explanation
whatsoever.
the goal is to remove gmap from mm, as mentioned in the cover letter
Right, but that cover letter will never reach git.
Also, why is that the goal? The cover letter does not tell me the reason
why you want to move that code.
