On Wed, 15 Jan 2025 09:56:11 +0100 Janosch Frank <frankja@xxxxxxxxxxxxx> wrote: > On 1/8/25 7:14 PM, Claudio Imbrenda wrote: > > Move some gmap shadowing functions from mm/gmap.c to kvm/vsie.c and > > kvm/kvm-s390.c . > > > > Why though? to start removing stuff from mm > > I don't really want to have gmap code in vsie.c > If you want to add a new mm/gmap-vsie.c then do so but I don't see a will do > need to move gmap code from mm to kvm and you give no explanation > whatsoever. the goal is to remove gmap from mm, as mentioned in the cover letter > > Maybe add a vsie-gmap.c in kvm but I'm not so thrilled about that for > the reasons mentioned above.