On Tue, Jan 07, 2025 at 02:41:51PM +0200, Nikolay Borisov wrote: > On 7.01.25 г. 9:37 ч., Tony Lindgren wrote: > > --- a/arch/x86/kvm/lapic.c > > +++ b/arch/x86/kvm/lapic.c > > @@ -139,6 +139,8 @@ __read_mostly DEFINE_STATIC_KEY_FALSE(kvm_has_noapic_vcpu); > > EXPORT_SYMBOL_GPL(kvm_has_noapic_vcpu); > > __read_mostly DEFINE_STATIC_KEY_DEFERRED_FALSE(apic_hw_disabled, HZ); > > +EXPORT_SYMBOL_GPL(apic_hw_disabled); > > Is it really required to expose this symbol? apic_hw_disabled is defined as > static inline in the header? For loadable modules yes, otherwise we'll get: ERROR: modpost: "apic_hw_disabled" [arch/x86/kvm/kvm-intel.ko] undefined! This is similar to the EXPORT_SYMBOL_GPL(kvm_has_noapic_vcpu) already there. Regards, Tony
