Hi, Here is v2 of TDX VM/vCPU creation series. As discussed earlier, non-nits from v1[0] have been applied and it’s ready to hand off to Paolo. A few items remain that may be worth further discussion: - Disable CET/PT in tdx_get_supported_xfam(), as these features haven’t been been tested. - The Retry loop around tdh_phymem_page_reclaim() in “KVM: TDX: create/destroy VM structure” likely can be dropped. - Drop support for TDX Module’s that don’t support MD_FIELD_ID_FEATURES0_TOPOLOGY_ENUM. [1] - Type-safety in to_vmx()/to_tdx(). [2] This series has 9 commits intended to collect acks from x86 maintainers. The first group of commits is for reading TDX static metadata for KVM to use: x86/virt/tdx: Share the global metadata structure for KVM to use x86/virt/tdx: Read essential global metadata for KVM The second group is for exporting a TDX keyid allocator for KVM to use: x86/virt/tdx: Add tdx_guest_keyid_alloc/free() to alloc and free TDX guest KeyID The third group is for exporting various SEAMCALLs needed by KVM for this series. SEAMCALL patches for the later TDX sections will come with those series’: x86/virt/tdx: Add SEAMCALL wrappers for TDX KeyID management x86/virt/tdx: Add SEAMCALL wrappers for TDX TD creation x86/virt/tdx: Add SEAMCALL wrappers for TDX vCPU creation x86/virt/tdx: Add SEAMCALL wrappers for TDX page cache management x86/virt/tdx: Add SEAMCALL wrappers for TDX VM/vCPU field access x86/virt/tdx: Add SEAMCALL wrappers for TDX flush operations This series is based off of a kvm-coco-queue commit and some pre-req series: 1. d659088d46df "KVM: x86/mmu: Prevent aliased memslot GFNs" (in kvm-coco-queue). 2. v6 of “TDX host: metadata reading tweaks, bug fix and info dump” 3. “KVM: VMX: Initialize TDX when loading KVM module” re-ordered from the commits in kvm-coco-queue It requires TDX module 1.5.06.00.0744[3], or later. This is due to removal of the workarounds for the lack of NO_RBP_MOD. Now NO_RBP_MOD is enabled, and this particular version of the TDX module has a NO_RBP_MOD related bug fix. The full KVM branch is here: https://github.com/intel/tdx/tree/tdx_kvm_dev-2024-10-30 Matching QEMU: https://github.com/intel-staging/qemu-tdx/tree/tdx-qemu-wip-2024-10-11 [0] https://lore.kernel.org/kvm/20240812224820.34826-1-rick.p.edgecombe@xxxxxxxxx/ [1] https://lore.kernel.org/kvm/d71540ab13e728d1326baae92e8ea82d00c08abe.camel@xxxxxxxxx/ [2] https://lore.kernel.org/kvm/89657f96-0ed1-4543-9074-f13f62cc4694@xxxxxxxxxx/ [3] https://github.com/intel/tdx-module/releases/tag/TDX_1.5.06 Isaku Yamahata (19): x86/virt/tdx: Add tdx_guest_keyid_alloc/free() to alloc and free TDX guest KeyID x86/virt/tdx: Add SEAMCALL wrappers for TDX KeyID management x86/virt/tdx: Add SEAMCALL wrappers for TDX TD creation x86/virt/tdx: Add SEAMCALL wrappers for TDX vCPU creation x86/virt/tdx: Add SEAMCALL wrappers for TDX page cache management x86/virt/tdx: Add SEAMCALL wrappers for TDX VM/vCPU field access x86/virt/tdx: Add SEAMCALL wrappers for TDX flush operations KVM: TDX: Add placeholders for TDX VM/vCPU structures KVM: TDX: Define TDX architectural definitions KVM: TDX: Add helper functions to print TDX SEAMCALL error KVM: TDX: Add place holder for TDX VM specific mem_enc_op ioctl KVM: TDX: Get system-wide info about TDX module on initialization KVM: TDX: create/destroy VM structure KVM: TDX: Support per-VM KVM_CAP_MAX_VCPUS extension check KVM: TDX: initialize VM with TDX specific parameters KVM: TDX: Make pmu_intel.c ignore guest TD case KVM: TDX: Don't offline the last cpu of one package when there's TDX guest KVM: TDX: create/free TDX vcpu structure KVM: TDX: Do TDX specific vcpu initialization Kai Huang (3): x86/virt/tdx: Share the global metadata structure for KVM to use KVM: TDX: Get TDX global information x86/virt/tdx: Read essential global metadata for KVM Sean Christopherson (1): KVM: TDX: Add TDX "architectural" error codes Xiaoyao Li (2): KVM: x86: Introduce KVM_TDX_GET_CPUID KVM: x86/mmu: Taking guest pa into consideration when calculate tdp level arch/x86/include/asm/kvm-x86-ops.h | 4 +- arch/x86/include/asm/kvm_host.h | 2 + arch/x86/include/asm/shared/tdx.h | 7 +- arch/x86/include/asm/tdx.h | 25 + .../tdx => include/asm}/tdx_global_metadata.h | 19 + arch/x86/include/uapi/asm/kvm.h | 59 + arch/x86/kvm/Kconfig | 2 + arch/x86/kvm/cpuid.c | 21 + arch/x86/kvm/cpuid.h | 3 + arch/x86/kvm/mmu/mmu.c | 9 +- arch/x86/kvm/vmx/main.c | 143 +- arch/x86/kvm/vmx/pmu_intel.c | 50 +- arch/x86/kvm/vmx/pmu_intel.h | 28 + arch/x86/kvm/vmx/tdx.c | 1369 ++++++++++++++++- arch/x86/kvm/vmx/tdx.h | 92 ++ arch/x86/kvm/vmx/tdx_arch.h | 165 ++ arch/x86/kvm/vmx/tdx_errno.h | 37 + arch/x86/kvm/vmx/vmx.h | 34 +- arch/x86/kvm/vmx/x86_ops.h | 24 + arch/x86/kvm/x86.c | 15 +- arch/x86/virt/vmx/tdx/tdx.c | 264 +++- arch/x86/virt/vmx/tdx/tdx.h | 39 +- arch/x86/virt/vmx/tdx/tdx_global_metadata.c | 46 + 23 files changed, 2391 insertions(+), 66 deletions(-) rename arch/x86/{virt/vmx/tdx => include/asm}/tdx_global_metadata.h (68%) create mode 100644 arch/x86/kvm/vmx/pmu_intel.h create mode 100644 arch/x86/kvm/vmx/tdx_arch.h create mode 100644 arch/x86/kvm/vmx/tdx_errno.h -- 2.47.0
