On Sun, 2025-01-05 at 22:12 +0000, Huang, Kai wrote: > I think we should delete this sentence in the new version of this patch since > this sentence is now obsolete which the new patch to read essential metadata for > KVM. > > This sentence was needed since originally we had code to do (pseudo): > > if (read_sys_metadata_field(MAX_VCPUS_PER_TD, &td_conf->max_vcpus_per_td)) > td_conf->max_vcpus_per_td = U16_MAX; > > Now the above code is removed in the patch which reads essential metadata for > KVM, and reading failure of this metadata will be fatal just like reading > others. > > It was removed because when I was trying to avoid special handling in the the > python script when generating the metadata reading code, I found the NO_BRP_MOD > feature was introduced to the module way after the MAX_VCPUS_PER_TD metadata was > added, therefore practically this field will always be present for the modules > that Linux support. > > Please let me know if you have different opinion, i.e., we should still do the > old way in the patch which reads essential metadata for KVM? Makes sense to me.
