Hi Sean, > I definitely don't object to the KVM change, but the if y'all expect developers > to actually honor the "rule", it needs to have teeth. As evidenced by a similar > rule in arch/x86/include/asm/bitops.h that also gets ignored, an #error that's > buried under an include guard and triggers on a macro that's never #undef'd is > quite useless. I went for the minimal change here. But if agreed, we could change bitmap.h to the pattern spinlock.h is using. Similar to your suggestion, yet with more readable names IMHO: #define __LINUX_INSIDE_SPINLOCK_H ... #undef __LINUX_INSIDE_SPINLOCK_H Happy hacking, Wolfram
Attachment:
signature.asc
Description: PGP signature
