On Mon, Dec 02, 2024 at 10:40:00AM +0000, Marc Zyngier wrote: > > +bool disable_uevent_notify; > > static? Yes. > <bikeshed-time> > I'd rather have a positive logic. Something like: > > +static bool uevent_notify = true; > +module_param(uevent_notify, bool, 0644); Choosing readability vs one byte in the data-section seems to be a good tradeoff. > </bikeshed-time> > > I would also expect some form of documentation in > Documentation/admin-guide/kernel-parameters.txt. Good point. I will add this in v3. Thanks, Bernhard
