On 11/13/24 13:44, Edgecombe, Rick P wrote: > Moving them to arch/x86 means we need to translate some things between KVM's > parlance and the rest of the kernels. This is extra wrapping. Another example > that was used in the old SEAMCALL wrappers was gpa_t, which KVM uses to refers > to a guest physical address. void * to the host direct map doesn't fit, so we > are back to u64 or a new gpa struct (like in the other thread) to speak to the > arch/x86 layers. I have zero issues with non-core x86 code doing a #include <linux/kvm_types.h>. Why not just use the KVM types?