> From: Liu, Yi L <yi.l.liu@xxxxxxxxx> > Sent: Monday, November 4, 2024 9:19 PM > > > +static inline int domain_setup_second_level(struct intel_iommu *iommu, > + struct dmar_domain *domain, > + struct device *dev, ioasid_t pasid, > + struct iommu_domain *old) > +{ > + if (old) > + return intel_pasid_replace_second_level(iommu, domain, > + dev, pasid); As commented let's pass the old domain pointer into the replace variants. Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>