On 02/09/2024 04:53, Aneesh Kumar K.V wrote: > Steven Price <steven.price@xxxxxxx> writes: > >> From: Sami Mujawar <sami.mujawar@xxxxxxx> > > ... > >> --- /dev/null >> +++ b/drivers/virt/coco/arm-cca-guest/Kconfig >> @@ -0,0 +1,11 @@ >> +config ARM_CCA_GUEST >> + tristate "Arm CCA Guest driver" >> + depends on ARM64 >> + default m >> + select TSM_REPORTS >> + help >> + The driver provides userspace interface to request and >> + attestation report from the Realm Management Monitor(RMM). >> + >> + If you choose 'M' here, this module will be called >> + arm-cca-guest. >> > > Can we rename the generic Kconfig variable to ARM_CCA_TSM_REPORT?. Also > should the directory be arm64-cca-guest? This matches the existing sev-guest and tdx-guest directories (and SEV_GUEST/TDX_GUEST_DRIVER kconfig), although I agree it's not great naming as it stands. But I'm also wondering if this will one day expand to include some other communication with the RMM. For example I know it's been discussed whether the guest should have involvement with firmware updates or migration to another host. So there's a reasonable chance we could end up renaming it back to a general "arm_cca_guest" if it grows more capabilities in the future. Steve
