On Wed, 25 Sept 2024 at 05:57, Danilo Krummrich <dakr@xxxxxxxxxx> wrote: > > On Tue, Sep 24, 2024 at 01:41:51PM -0300, Jason Gunthorpe wrote: > > On Tue, Sep 24, 2024 at 12:50:55AM +0200, Danilo Krummrich wrote: > > > > > > From the VFIO side I would like to see something like this merged in > > > > nearish future as it would bring a previously out of tree approach to > > > > be fully intree using our modern infrastructure. This is a big win for > > > > the VFIO world. > > > > > > > > As a commercial product this will be backported extensively to many > > > > old kernels and that is harder/impossible if it isn't exclusively in > > > > C. So, I think nova needs to co-exist in some way. > > > > > > We'll surely not support two drivers for the same thing in the long term, > > > neither does it make sense, nor is it sustainable. > > > > What is being done here is the normal correct kernel thing to > > do. Refactor the shared core code into a module and stick higher level > > stuff on top of it. Ideally Nova/Nouveau would exist as peers > > implementing DRM subsystem on this shared core infrastructure. We've > > done this sort of thing before in other places in the kernel. It has > > been proven to work well. > > So, that's where you have the wrong understanding of what we're working on: You > seem to think that Nova is just another DRM subsystem layer on top of the NVKM > parts (what you call the core driver) of Nouveau. > > But the whole point of Nova is to replace the NVKM parts of Nouveau, since > that's where the problems we want to solve reside in. Just to re-emphasise for Jason who might not be as across this stuff, NVKM replacement with rust is the main reason for the nova project, 100% the driving force for nova is the unstable NVIDIA firmware API. The ability to use rust proc-macros to hide the NVIDIA instability instead of trying to do it in C by either generators or abusing C macros (which I don't think are sufficient). The lower level nvkm driver needs to start being in rust before we can add support for newer stuff. Now there is possibly some scope about evolving the rust pieces in it as, rust wrapped in C APIs to make things easier for backports or avoid some pitfalls, but that is a discussion that we need to have here. I think the idea of a nova drm and nova core driver architecture is acceptable to most of us, but long term trying to main a nouveau based nvkm is definitely not acceptable due to the unstable firmware APIs. Dave.
