On Thu, Sep 12, 2024 at 11:49:10AM +0300, Dan Carpenter wrote: > The "array_count" value comes from the copy_from_user() in > vfio_pci_ioctl_pci_hot_reset(). If the user passes a value larger than > INT_MAX then we'll pass a negative value to kcalloc() which triggers an > allocation failure and a stack trace. > > It's better to make the type unsigned so that if (array_count > count) > returns -EINVAL instead. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/vfio/pci/vfio_pci_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx> Jason
