On Thu, 12 Sept 2024 at 12:59, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote: > > On 12/9/24 09:38, Pierrick Bouvier wrote: > > This patch is part of a series that moves towards a consistent use of > > g_assert_not_reached() rather than an ad hoc mix of different > > assertion mechanisms. > > > > Reviewed-by: Richard Henderson <richard.henderson@xxxxxxxxxx> > > Reviewed-by: Thomas Huth <thuth@xxxxxxxxxx> > > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@xxxxxxxxxx> > > --- > > include/hw/s390x/cpu-topology.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > We usually don't precise "include/" in patch subject: > we treat include/FOO as part of FOO area. I would say either is OK -- if you do git log --oneline | grep ' include' |less you can see plenty of examples where 'include' was used in the subject-area prefix, especially if, as here, we're changing just one file. -- PMM
