On Wed, 2024-09-11 at 16:52 +0800, Chao Gao wrote: > > + /* > > + * Don't rely on GFN's attribute tracking xarray to prevent EPT > > violation > > + * loops. > > + */ > > The comment seems a bit odd to me. We cannot use the gfn attribute from the > attribute xarray simply because here we need to determine if *this access* is > to private memory, which may not match the gfn attribute. Even if there are > other ways to prevent an infinite EPT violation loop, we still need to check > the shared bit in the faulting GPA. Yea this comment is not super informative. We can probably just drop it.