Re: [PATCH] KVM: svm: Fix erratum 383 check for 32-bit hosts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 26, 2010 at 03:56:43AM -0400, Jan Kiszka wrote:
> Roedel, Joerg wrote:
> > On Wed, May 26, 2010 at 03:11:17AM -0400, Jan Kiszka wrote:
> >> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> >>
> >> This overflow should have left the check broken behind for 32-bit hosts.
> > 
> > The check itself should work but it gives a compile warning for me (at
> > least in my small userspace test I did ;) Good catch, thanks.
> 
> To my understanding, the test degraded to value != 0x00010015. That may
> not have the intended effect, no?

I tested this with a small test program in userspace (compiled with
gcc -m32) and the check actually works. But I get a compile warning
because the constant is too large for type long. So I think the check
should work in the 32 bit kernel too.

	Joerg


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux