On Tue, Jul 30, 2024 at 10:10:29AM +0200, Markus Armbruster wrote: > QAPI's 'prefix' feature can make the connection between enumeration > type and its constants less than obvious. It's best used with > restraint. > > QCryptoRSAPaddingAlgorithm has a 'prefix' that overrides the generated > enumeration constants' prefix to QCRYPTO_RSA_PADDING_ALG. > > We could simply drop 'prefix', but then the prefix becomes > QCRYPTO_RSA_PADDING_ALGORITHM, which is rather long. > > We could additionally rename the type to QCryptoRSAPaddingAlg, but I > think the abbreviation "alg" is less than clear. > > Rename the type to QCryptoRSAPaddingAlgo instead. The prefix becomes > QCRYPTO_RSA_PADDING_ALGO. > > Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx> > --- > qapi/crypto.json | 9 ++++----- > backends/cryptodev-builtin.c | 6 +++--- > backends/cryptodev-lkcf.c | 10 +++++----- > tests/bench/benchmark-crypto-akcipher.c | 12 ++++++------ > tests/unit/test-crypto-akcipher.c | 10 +++++----- > crypto/akcipher-gcrypt.c.inc | 18 +++++++++--------- > crypto/akcipher-nettle.c.inc | 18 +++++++++--------- > 7 files changed, 41 insertions(+), 42 deletions(-) Acked-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
