On Tue, Jul 30, 2024 at 10:10:28AM +0200, Markus Armbruster wrote: > QAPI's 'prefix' feature can make the connection between enumeration > type and its constants less than obvious. It's best used with > restraint. > > QCryptoAkCipherAlgorithm has a 'prefix' that overrides the generated > enumeration constants' prefix to QCRYPTO_AKCIPHER_ALG. > > We could simply drop 'prefix', but then the prefix becomes > QCRYPTO_AK_CIPHER_ALGORITHM, which is rather long. > > We could additionally rename the type to QCryptoAkCipherAlg, but I > think the abbreviation "alg" is less than clear. > > Rename the type to QCryptoAkCipherAlgo instead. The prefix becomes > QCRYPTO_AK_CIPHER_ALGO. > > Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx> > --- > qapi/crypto.json | 7 +++---- > crypto/akcipherpriv.h | 2 +- > backends/cryptodev-builtin.c | 4 ++-- > backends/cryptodev-lkcf.c | 4 ++-- > crypto/akcipher.c | 2 +- > tests/bench/benchmark-crypto-akcipher.c | 2 +- > tests/unit/test-crypto-akcipher.c | 10 +++++----- > crypto/akcipher-gcrypt.c.inc | 4 ++-- > crypto/akcipher-nettle.c.inc | 4 ++-- > 9 files changed, 19 insertions(+), 20 deletions(-) Acked-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
