On 30/07/2024 3:31 am, Sean Christopherson wrote:
On Sat, Jun 29, 2024, Kai Huang wrote:
On Fri, 2024-06-28 at 15:55 -0700, Sean Christopherson wrote:
On Mon, 24 Jun 2024 09:20:16 +0800, flyingpenghao@xxxxxxxxx wrote:
Some variables allocated in kvm_arch_vcpu_ioctl are released when
the function exits, so there is no need to set GFP_KERNEL_ACCOUNT.
Applied to kvm-x86 misc, thanks!
[1/1] KVM: X86: Remove unnecessary GFP_KERNEL_ACCOUNT for temporary variables
https://github.com/kvm-x86/linux/commit/dd103407ca31
--
https://github.com/kvm-x86/linux/tree/next
Hi Sean,
Sorry, lost this at the bottom of my inbox.
Thanks for getting back to this. :-)
I thought we should use _ACCOUNT even for temporary variables.
Heh, that's what I thought too.
[*] https://lore.kernel.org/all/c0122f66-f428-417e-a360-b25fc0f154a0@p183
Thanks for the info.
Looking at Paolo's reply and by applying this patch, it seems we agreed
we can just use GFP_KERNEL (e.g., GFP_USER isn't needed too)?
Anyway I've sent a patch to change handle_encls_ecreate():
https://lore.kernel.org/kvm/20240715101224.90958-1-kai.huang@xxxxxxxxx/T/
