On Fri, 2024-06-28 at 15:55 -0700, Sean Christopherson wrote: > On Mon, 24 Jun 2024 09:20:16 +0800, flyingpenghao@xxxxxxxxx wrote: > > Some variables allocated in kvm_arch_vcpu_ioctl are released when > > the function exits, so there is no need to set GFP_KERNEL_ACCOUNT. > > Applied to kvm-x86 misc, thanks! > > [1/1] KVM: X86: Remove unnecessary GFP_KERNEL_ACCOUNT for temporary variables > https://github.com/kvm-x86/linux/commit/dd103407ca31 > > -- > https://github.com/kvm-x86/linux/tree/next > Hi Sean, I thought we should use _ACCOUNT even for temporary variables. Should I send a patch to do below? :-) --- a/arch/x86/kvm/vmx/sgx.c +++ b/arch/x86/kvm/vmx/sgx.c @@ -274,7 +274,7 @@ static int handle_encls_ecreate(struct kvm_vcpu *vcpu) * simultaneously set SGX_ATTR_PROVISIONKEY to bypass the check to * enforce restriction of access to the PROVISIONKEY. */ - contents = (struct sgx_secs *)__get_free_page(GFP_KERNEL_ACCOUNT); + contents = (struct sgx_secs *)__get_free_page(GFP_KERNEL); if (!contents) return -ENOMEM;
