On Tue, May 25, 2010 at 3:10 PM, Avi Kivity <avi@xxxxxxxxxx> wrote: > On 05/25/2010 03:01 PM, Mohammed Gamal wrote: >>> >>> How does the user distinguish between KVM_EXIT_FAIL_ENTRY due to an exit >>> reason with bit 31 set and vmlauch/vmresume failure (vmx->fail set)? We >>> need separate exit codes (with documentation in api.txt). >>> >> >> In both cases the vm fails entry, and I don't think the hardware entry >> failure reason codes would overlap between the vmx->fail case and exit >> reasons with bit 31 set, so why should there be such distinction >> between both cases? >> > > Only 5 more error codes (28->33) and we have overlap. > > If you return the new codes with bit 31 still set then we can use the > existing KVM_EXIT_FAIL_ENTRY. That'd be a better idea. > > > -- > error compiling committee.c: too many arguments to function > > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html