On Tue, May 25, 2010 at 2:45 PM, Avi Kivity <avi@xxxxxxxxxx> wrote:
> On 05/24/2010 01:01 AM, Mohammed Gamal wrote:
>>
>> The vmexit handler returns KVM_EXIT_UNKNOWN since there is no handler
>> for vmentry failures. This intercepts vmentry failures and returns
>> KVM_FAIL_ENTRY to userspace instead.
>>
>> Signed-off-by: Mohammed Gamal<m.gamal005@xxxxxxxxx>
>> ---
>> arch/x86/kvm/vmx.c | 7 +++++++
>> 1 files changed, 7 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index 99ae513..4edcffb 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -3665,6 +3665,13 @@ static int vmx_handle_exit(struct kvm_vcpu *vcpu)
>> if (enable_ept&& is_paging(vcpu))
>> vcpu->arch.cr3 = vmcs_readl(GUEST_CR3);
>>
>> + if (exit_reason& VMX_EXIT_REASONS_FAILED_VMENTRY) {
>> + vcpu->run->exit_reason = KVM_EXIT_FAIL_ENTRY;
>> + vcpu->run->fail_entry.hardware_entry_failure_reason
>> + = exit_reason& ~VMX_EXIT_REASONS_FAILED_VMENTRY;
>> + return 0;
>> + }
>> +
>> if (unlikely(vmx->fail)) {
>> vcpu->run->exit_reason = KVM_EXIT_FAIL_ENTRY;
>> vcpu->run->fail_entry.hardware_entry_failure_reason
>>
>
> How does the user distinguish between KVM_EXIT_FAIL_ENTRY due to an exit
> reason with bit 31 set and vmlauch/vmresume failure (vmx->fail set)? We
> need separate exit codes (with documentation in api.txt).
In both cases the vm fails entry, and I don't think the hardware entry
failure reason codes would overlap between the vmx->fail case and exit
reasons with bit 31 set, so why should there be such distinction
between both cases?
>
> --
> error compiling committee.c: too many arguments to function
>
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
