On Wed, Jul 24, 2024 at 01:47:16PM +0100, Daniel P. Berrangé wrote: > Date: Wed, 24 Jul 2024 13:47:16 +0100 > From: "Daniel P. Berrangé" <berrange@xxxxxxxxxx> > Subject: Re: [PATCH 2/8] qapi/qom: Introduce smp-cache object > > On Wed, Jul 24, 2024 at 01:35:17PM +0200, Markus Armbruster wrote: > > Zhao Liu <zhao1.liu@xxxxxxxxx> writes: > > > > > Hi Markus, > > >> SmpCachesProperties and SmpCacheProperties would put the singular > > >> vs. plural where it belongs. Sounds a bit awkward to me, though. > > >> Naming is hard. > > > > > > For SmpCachesProperties, it's easy to overlook the first "s". > > > > > >> Other ideas, anybody? > > > > > > Maybe SmpCacheOptions or SmpCachesPropertyWrapper? > > > > I wonder why we have a single QOM object to configure all caches, and > > not one QOM object per cache. > > Previous versions of this series were augmenting the existing > -smp command line. Ah, yes, since -smp, as a sugar option of -machine, doesn't support JSON. In -smp, we need to use keyval's style to configure as: -smp caches.0.name=l1i,caches.0.topo=core I think JSON is the more elegant way to go, so I chose -object. > Now the design has switched to use -object, > I agree that it'd be simplest to just have one -object flag > added per cache level we want to defnie. > OK. Thanks, Zhao
