On Wed, Jul 24, 2024 at 01:35:17PM +0200, Markus Armbruster wrote: > Zhao Liu <zhao1.liu@xxxxxxxxx> writes: > > > Hi Markus, > >> SmpCachesProperties and SmpCacheProperties would put the singular > >> vs. plural where it belongs. Sounds a bit awkward to me, though. > >> Naming is hard. > > > > For SmpCachesProperties, it's easy to overlook the first "s". > > > >> Other ideas, anybody? > > > > Maybe SmpCacheOptions or SmpCachesPropertyWrapper? > > I wonder why we have a single QOM object to configure all caches, and > not one QOM object per cache. Previous versions of this series were augmenting the existing -smp command line. Now the design has switched to use -object, I agree that it'd be simplest to just have one -object flag added per cache level we want to defnie. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
